This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 220
Product Details block: Remove the fill color of the Product Details icon and move it to the icons library #9503
Merged
thealexandrelara
merged 1 commit into
trunk
from
fix/9417-remove-fill-color-of-product-details-icon
May 19, 2023
Merged
Product Details block: Remove the fill color of the Product Details icon and move it to the icons library #9503
thealexandrelara
merged 1 commit into
trunk
from
fix/9417-remove-fill-color-of-product-details-icon
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
thealexandrelara
changed the title
Remove the fill color of the Product Details icon and move it to the …
Product Details block: Remove the fill color of the Product Details icon and move it to the icons library
May 18, 2023
Size Change: +562 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
thealexandrelara
added
type: bug
The issue/PR concerns a confirmed bug.
block: product details
Issues related to the Product Details block
labels
May 18, 2023
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
May 18, 2023 18:03
gigitux
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
thealexandrelara
deleted the
fix/9417-remove-fill-color-of-product-details-icon
branch
May 19, 2023 15:09
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: product details
Issues related to the Product Details block
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 411d9ef
When selecting the Product Details block in the blocks list on the Site Editor, the icon color is always set to black. The expected behavior is that when selecting the icon, its color should change to white.
Walkthrough
🤖 Generated by Copilot at 411d9ef
productDetails
icon to@woocommerce/icons
library (link, link)Icon
component andproductDetails
icon to render Product Details block icon in the editor (link, link)img
element withIcon
component for better scaling and accessibility (link)Fixes #9417
Accessibility
prefers-reduced-motion
Other Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog