This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Make Mini-Cart block work well with caching plugins #9493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/mini-cart/utils/test/data.ts
|
|
Size Change: +1.65 kB (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
adf7954 to
4a1da27
Compare
a42a1ee to
d12e2b7
Compare
d12e2b7 to
2aa687d
Compare
Aljullu
commented
May 17, 2023
Comment on lines
+260
to
+262
| act( () => { | ||
| userEvent.click( removeRating4Button ); | ||
| } ); |
There was a problem hiding this comment.
I have no idea why these tests suddenly stopped passing, so I needed to add atc() here.
Aljullu
commented
May 17, 2023
There was a problem hiding this comment.
Heads-up that I didn't change anything in the code of this file, I just moved it over from assets/js/blocks/mini-cart/frontend.ts.
gigitux
suggested changes
May 22, 2023
gigitux
approved these changes
May 22, 2023
7 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9353.
Accessibility
prefers-reduced-motionTesting
Automated Tests
User Facing Testing
With your admin user:
In a private/incognito window without being logged in:
3. In the frontend visit any page. This will cache the page without products in the cart.
With your admin user:
4. Add some products to your cart.
5. Visit the same page from step 3.
6. Notice the Mini Cart totals do include the products you added in step 4, even though it's serving the cached version of step 3.
WooCommerce Visibility
Performance Impact
This PR adds an extra request to all page views were the Mini-Cart block is present. It also increases a the weight of Mini-Cart block scripts on page load. However, I think the benefits of this outweight the performance impact.
Changelog