-
Notifications
You must be signed in to change notification settings - Fork 219
Global Styles: Fix radio control overlap when font-size is small #9436
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +19 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @tarunvijwani. The change works as expected. Let's ⛴️ it.
Just one minor comment: When reviewing it, it wasn't clear to me that I manually had to set the font size to something tiny, e.g. 0,7 rem
. I wonder if we should update the testing instructions accordingly and potentially add the following screenshot:
Fixes #9193
Radio buttons under the shipping options overlapped with the label if the font size was small.
With this PR, we are fixing the styles for input radio control.
Changes in the PR
Accessibility
prefers-reduced-motion
Other Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog