This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add new Product collections: featured collections pattern
#9388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +611 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
kmanijak
suggested changes
May 9, 2023
Ouch, I just pushed the change, not sure how I missed that 🙈 |
kmanijak
reviewed
May 10, 2023
There was a problem hiding this comment.
When using a light-colored style like Sherbet, the button's text is unreadable:
When using dark-colored style like Pitch, the headings are unreadable:
I'm not sure if that's up to the merchant to adjust if necessary or should work out of the box. I assume you may have more context. 🤔
Otherwise, it looks good!
|
Thanks, @kmanijak, I've added colors to the title and button, we agreed on adding more opinionated styles. But it still does not work too well with the Sherbet theme :( |
roykho
approved these changes
May 11, 2023
There was a problem hiding this comment.
LGTM! I don't think we can successfully accommodate every theme styles out there. For now this looked fine on several themes I've tested. The only thing worth mentioning is the image of the Beats headphones. Recently we changed an image of a Nike shoes to something else as we err on the side of caution not to include branded images. Other than that I am approving it.
kmanijak
approved these changes
May 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
Product collections: featured collectionspattern.Fixes #9106
Screenshots
Design
Testing
User-Facing Testing
Product collections: featured collectionspattern appears under the WooCommerce category dropdown.WooCommerce Visibility
Changelog