-
Notifications
You must be signed in to change notification settings - Fork 219
Mini Cart Contents block: set minimum width #9196
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +99 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's little bug and I made a suggestion that should fix it 👍
Co-authored-by: Karol Manijak <karol.manijak@automattic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this so quickly! Here are the testing results:
✅ Setting width below 300px and moving focus somewhere else, changes the value to 300px;
✅ Removing the input value, changes the value to 480px;
✅ Setting width to an allowed value is persisted correctly;
✅ When building the plugin as if it is WC Core version, no input for editing the width is shown inside Mini Cart template part.
* Mini Cart Contents block: set minimum width * Mini Cart Contents block: allow changing the width only in the feature plugin * Allow resetting the Mini Cart Contents width to the default * Update assets/js/blocks/mini-cart/mini-cart-contents/edit.tsx Co-authored-by: Karol Manijak <karol.manijak@automattic.com> --------- Co-authored-by: Karol Manijak <karol.manijak@automattic.com>
This PR introduces three changes:
300px
, but we can change it if needed.UnitControl
is an experimental component, so I think it's better to have it only in the feature plugin for now.Testing
User Facing Testing
Feature plugin testing
Internal testing
WOOCOMMERCE_BLOCKS_PHASE=1 npm run build
).WooCommerce Visibility
Changelog