This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Implement new Hero Product – Split
pattern
#9191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
danielwrobert
force-pushed
the
add/hero-product-split-pattern
branch
from
April 28, 2023 17:24
a0adbed
to
ecc8ad0
Compare
danielwrobert
added
the
type: enhancement
The issue is a request for an enhancement.
label
Apr 28, 2023
danielwrobert
force-pushed
the
add/hero-product-split-pattern
branch
from
April 28, 2023 19:23
ecc8ad0
to
577b1bd
Compare
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
April 28, 2023 19:23
danielwrobert
changed the title
Implement new
Implement new Apr 28, 2023
Hero product: Split
patternHero Product – Split
pattern
albarin
reviewed
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds a new pattern for a hero product banner with a 50/50 split, heading and CTA on left and product image on right. Uses the Media + Text block.
danielwrobert
force-pushed
the
add/hero-product-split-pattern
branch
from
May 2, 2023 19:11
577b1bd
to
c9d9e71
Compare
I think the group wrapper was constraining the block when added to a Post or Page. This should be fixed in cb721d0. |
albarin
approved these changes
May 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new pattern for a hero product banner with a 50/50 split, heading and CTA on left and product image on right.
Under the hood, it takes advantage of the Media + Image block, with some preset configurations.
Fixes #9043
Screenshots
Testing
WooCommerce Hero Product – Split
pattern appears under the WooCommerce category dropdown.WooCommerce Visibility
Performance Impact
Changelog