This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
Blockfied Single Product Template: Add support for template for specific product #9069
Merged
gigitux
merged 2 commits into
trunk
from
9067-single-product-template-gallery-thumbnails-broke-for-specific-product-templates
Apr 17, 2023
Merged
Blockfied Single Product Template: Add support for template for specific product #9069
gigitux
merged 2 commits into
trunk
from
9067-single-product-template-gallery-thumbnails-broke-for-specific-product-templates
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
The issue/PR concerns a confirmed bug.
skip-changelog
PRs that you don't want to appear in the changelog.
labels
Apr 17, 2023
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
April 17, 2023 11:07
gigitux
force-pushed
the
9067-single-product-template-gallery-thumbnails-broke-for-specific-product-templates
branch
from
April 17, 2023 11:07
067b1f8
to
10da9fd
Compare
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
…ails-broke-for-specific-product-templates
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
tjcafferkey
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gigitux
deleted the
9067-single-product-template-gallery-thumbnails-broke-for-specific-product-templates
branch
April 17, 2023 12:23
gigitux
added a commit
that referenced
this pull request
Apr 18, 2023
gigitux
added a commit
that referenced
this pull request
Apr 18, 2023
* Single Product Template - Compatibility Layer: don't skip custom HTML (#9075) * Fix: tax_query should be calculated only if __woocommerceAttributes is valid (#9049) This commit refactors the update_rest_query method in the ProductQuery.php file to improve code readability. It simplifies conditional expressions by introducing variables for clarity, and uses ternary operators to streamline the logic. * Blockfied Single Product Template: Add support for template for specific product (#9069) * Product Price Block: remove ProductSelector (#8980) * Empty commit for release pull request * Make Woo_Directive_Store PHP 7.3 compatible (#9033) * update version * add changelog * add testing instructions * update zip link file testing * Update docs/internal-developers/testing/releases/1001.md Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> --------- Co-authored-by: Luigi Teschio <gigitux@gmail.com> Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Viktor Szépe <viktor@szepe.net> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
skip-changelog
PRs that you don't want to appear in the changelog.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slug of the template for a specific product is single-product-{name-product}. For this reason, with the previous check, the Compatibility Layer wasn't loaded on templates for specific products. This PR fixes the behavior.
Fixes #9067
Testing
User Facing Testing
WooCommerce Visibility