This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Display Mini Cart overlay in template part editor #9014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: enhancement
The issue is a request for an enhancement.
block: mini-cart
Issues related to the Mini-Cart block.
labels
Apr 12, 2023
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
April 12, 2023 11:02
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +116 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
danielwrobert
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice enhancement! Thanks for working on it!
Everything LGTM - code looks good and straightforward, tests as described! 🚀
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Apr 12, 2023
Aljullu
force-pushed
the
fix/mini-cart-editor-overlay
branch
from
April 14, 2023 08:22
44598bb
to
42651c2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: mini-cart
Issues related to the Mini-Cart block.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the overlay to the Mini Cart template part editor so it's clear which part is the editable template part and which part is the background.
Testing
User Facing Testing
WooCommerce Visibility
Changelog