This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Customer Account block: Fix padding for the block in the Editor #9009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +86 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
kmanijak
reviewed
Apr 12, 2023
There was a problem hiding this comment.
What do you think about making similar padding on the frontend to increase the click area, that may be especially useful for mobile shoppers.
I placed the Customer Account and Mini Cart next to each other:
Here you can see a comparison of interactive area on the frontend:
| Customer Account | Mini Cart |
|---|---|
 |
 |
Let me know if that's something you think is worth addressing, otherwise, it works well! 💪
Hey @kmanijak thank you for reviewing this PR, I think it is a great suggestion, I just pushed a change with what you suggested, so now the icon has a padding around it 🙌 |
|
Oooh, I missed this! Thanks for fixing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Customer Account block currently has no padding set to it. This makes the clickable area too small for this block when the user is on the Editor page.
This PR solves that by adding a padding equal to what we have for the Mini Cart block. I also refactored the CSS classes to follow our guidelines
Fixes #8942
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog