This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Prevent error when entering postcode for countries without specific validation rules #8987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer needed
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +12 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
nielslange
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Thanks for working on this, @opr. The change works as expected. Let's 🛳 this (un-)blocker.
|
Thanks @nielslange - I re-ran the tests and the checkout ones are not failing, seems like the current fails are not related to my changes so I will go ahead with the merge. 🙌🏼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8503 we added a regression when users entered certain countries (e.g. Afghanistan or Albania) and then could not use the Postcode field, or a block error appeared preventing address entry.
This PR fixes that by checking whether the country has any regex rules before validating. If it does not we fall back to allowing the postcode through.
It also modifies the tests to test for a country we know is problematic (Albania).
Fixes #8983
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog