This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Check for address on shippingData
#8878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +12 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
mikejolley
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
@opr code checks out and aligns with what we had previously. I have not tested with a real Stripe account—Ill trust you there as I don't have keys any more :p
We should include a dev note.
|
The failing test is related to
I don't think it is caused by this PR. Thanks for the review Mike. |
Aljullu
pushed a commit
that referenced
this pull request
Mar 28, 2023
Aljullu
pushed a commit
that referenced
this pull request
Mar 28, 2023
Aljullu
added a commit
that referenced
this pull request
Mar 28, 2023
* Empty commit for release pull request * Update version numbers to 9.8.3 * Add 9.8.3 changelog * Fix save changes bug in Firefox browser (#8754) * Fix border styles not visible in the editor in Featured Product and Featured Category blocks in core (#8838) * Check for address on shippingData (#8878) * Add 9.8.3 testing steps --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com>
tarunvijwani
pushed a commit
that referenced
this pull request
Mar 29, 2023
opr
added a commit
that referenced
this pull request
Apr 3, 2023
* Empty commit for release pull request * Add WC Blocks 9.9.0 changelog * Update supported versions for WC Blocks 9.9.0 * Update versions for WC Blocks 9.9.0 * Add testing notes for 9.90 release * Update testing instructions Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> * Remove active the latest trunk part from the testing instructions Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> * Add instructions to activate WP release candidates - Add the editor type for each reference. - Add instructions to activate WP release candidate * Fix readme file reference * Fix unlinked border widths in WP 6.2 (#8893) * Check for address on shippingData (#8878) * Make a Single Product conversion enabled in Core, but keep the Product Archive behind experimental flag (#8907) * Remove `isExperimentalBuild` Checks in Classic Template Block (#8902) * Remove isExperimentalBuild checks. By removing the `isExperimentalBuild` conditional checks in the Classic Template block, we can ensure the features added in #8324 will land in WooCommerce Core and are not limited to the feature plugin. See p1680000654295729-slack-C02UBB1EPEF for additional context. * Revert isExperimentalBuild removal on registration The conditional `isExperimentalBuild` conditional check that was wrapping some conditional registration of the classic template block seems to be unrelated to the template conversion/migration. This is something we can revisit and test separately but should not be included in this changeset. * Update changelog and testing instructions to include cherry-picked PRs * Update release zip * Update readme to be in correct order --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tarun Vijwani <tarun.vijwani@automattic.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: kmanijak <karol.manijak@automattic.com> Co-authored-by: Daniel W. Robert <danielwrobert@users.noreply.github.com> Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where observers returning
addressin theshippingDataobject would not get the address applied to the order.In #8163 we added checks to see if
shippingDatawas used, rather thanshippingAddress, and if so we would extract the address from there and use that, however we did not correctly identify that the address was stored in a property onshippingData.Fixes #8785
Testing
Automated Tests
UserInternal TestingshippingDatawith an address property, like so:Set by Stripe plugin.WooCommerce Visibility
Dev note
In Check for address on shippingData (#8878) we fixed a regression with our payment processing observers. Previously, payment processing observers that returned a
shippingDataobject with anaddressproperty would overwrite the customer's shipping address with the supplied address, however in #8163 this was inadvertently removed.This has now been changed so that these extensions work as they did (but passing the address via
shippingData.addressis still deprecated, and the preferred method is to pass it viashippingAddresswhich should be a flat address object).To migrate away from the deprecated
shippingDataproperty to using the newshippingAddressproperty, you will need to update your observer's return value. The address, previously stored the inshippingData.addressshould be moved intoshippingAddresswhich will be a flat object containing only the address data.Old observer response value
New observer response value - note the
shippingAddressvalue is a flat objectChangelog