This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Related Products: Move Notice block to the Inspector Control section #8843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +22 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
LGTM, we should add some labels to the PR. Also, from the testing steps:
- On the top right of the page, click on the three dots icon and open the Code Editor (or just hit Shift + Option + Command + M on the Mac);
- Replace the default
wp-groupsection with thewp-groupsection inside the templates/templates/blockified/single-product.html file of this PR.
Could these steps be replaced with "Add the Related Products block"? Or is there any reason to manually copy and paste the template?
assets/js/atomic/blocks/product-elements/related-products/editor.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
I was following the testing steps from the issue, but you're correct, I just modified the test steps to what you suggested 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Notice block that existed inside the Related Products to the Inspector Control section (on the sidebar).
Fixes #8817
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog