This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add theme-level global styles to Cart and Checkout block #8809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -8.89 kB (-1%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
…ors » Buttons` (#8844) * Add GS support for button colors in Checkout block * Sync button hover effect with GB
Aljullu
reviewed
Apr 20, 2023
There was a problem hiding this comment.
I didn't review the code, but after some smoke testing I noticed:
Color
- Cart and Checkout: buttons can be hovered and they lose their style. This happens both, in the editor and the frontend:
Enregistrament.de.pantalla.des.de.2023-04-20.19-29-19.webm
- Cart & Checkout: link color seems to work in the editor, but not the frontend:
| Editor | Frontend |
|---|---|
 |
 |
- Checkout: heading background is full-width in editor but smaller in the frontend:
| Editor | Frontend |
|---|---|
 |
 |
Typography
- Checkout: heading appearance (italics and bold) is not respected in the editor:
| Editor | Frontend |
|---|---|
 |
 |
- Cart and Checkout: heading line-height is not respected.
- Checkout: text appearance (italics and bold) is not respected in the editor:
| Editor | Frontend |
|---|---|
 |
 |
Besides that, everything else seemed to be working well. 👌
|
Thanks for your review, @Aljullu! 🙌 @tarunvijwani asked me if I can take care of this PR given that he's on porter rotation. The following issues, which you reported, are related to the TT3 theme:
The following issues have been fixed:
Screenshot
In the screenshot, you might notice that the |
Aljullu
reviewed
Apr 21, 2023
There was a problem hiding this comment.
Thanks for the update, @nielslange!
I did another round of testing and couldn't find anything besides what has already been mentioned.
The following issues have been fixed:
Confirming this. 👌
mikejolley
approved these changes
Apr 21, 2023
|
@mikejolley Thank you for reviewing the PR. I have created a new ticket to tackle this problem in the sprint: #9164. |
|
Markdown and Playwright tests are getting failed. Asked for confirmation to merge the PR: p1682089388117269-slack-C02UBB1EPEF |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8710
With this PR, we're enabling the theme-level global styles in Cart and Checkout blocks.
Changes in the PR
Accessibility
prefers-reduced-motionTesting
Automated Tests
User Facing Testing
WP Admin»Apperance»Editor.TypographyandColorsettings.Screen recording:
Screen.Recording.2023-04-18.at.11.22.34.AM.mov
WooCommerce Visibility
Performance Impact
Changelog