This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add the ability to change the background and text colors of the Mini Cart block "Start shopping" button. #8766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +12 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Aljullu
reviewed
Mar 16, 2023
|
Hmmm, weird, I cannot reproduce, it's applying in the frontend as well for me 🤔 |
Aljullu
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Oh, never mind. It's working now. Not sure what was happening. 😕
Changes LGTM so approving. However, I wonder if as a follow-up we should work on adding the option to change the style between 'Outline' and 'Default' as it's possible in Button blocks:
Otherwise, the border can't be removed and it looks a bit weird:
What do you think?
I just figured it out, I was testing with one theme but was editing the template part of another one. I should have opened the Mini Cart template part again after switching themes before making more edits. 😅 |
That makes sense, I'll add an issue for it. 👍 |
Start shopping button
Open
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add styles to the
Start shoppingbutton on the emptyMini cartblock.It is part of #8736, the
View my cartandGo to checkoutbuttons will be addressed on a separate PR.Testing
User-Facing Testing
Mini cartblock to the header template of your site.Site Editorand edit theMini carttemplate part.List viewand select theEmpty Mini Cart view.Start shoppingbutton and check that you can change the background and text colors of the button.WooCommerce Visibility
Changelog