This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update wc/store/cart to handle hidden shipping costs until address is entered
#8682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borrowed from #8141
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/cart/cart-line-items-table/cart-line-item-row.tsx
assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/edit.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-methods-block/edit.tsx assets/js/data/cart/reducers.ts assets/js/editor-components/expandable-search-list-item/expandable-search-list-item.tsx assets/js/editor-components/product-attribute-term-control/index.js assets/js/editor-components/search-list-control/search-list-control.tsx assets/js/utils/attributes.ts |
|
Size Change: +682 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
Required because importing from the index causes the validation data store to register twice
|
I believe the test failure in https://github.com/woocommerce/woocommerce-blocks/actions/runs/4379470384/jobs/7665457556 is not related to this PR. |
nielslange
reviewed
Mar 10, 2023
This reverts commit 9967dc0.
nielslange
approved these changes
Mar 13, 2023
|
I'm not going to block this work being merged but I should point out, if we end up going with a modal or step based flow on the checkout, tracking whether the address has been pushed will no longer be necessary because the shipping step won't be refreshed until the user has input their address cc @ralucaStan |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on
add/hide-costs-control#8680 and is part of the work required to satisfy #7895In this PR, the changes made include updates to the
wc/store/cartdata store, to track when an address is complete.These changes are required the purposes of showing shipping rates only when an address is complete, and also tracks whether the complete address has been pushed to the server. This check is required to prevent showing outdated shipping methods in the event that an address becomes complete, but has not been pushed to the server yet, and shipping methods are not updated.
This had to be done in the data store rather than the API because the setting to Hide shipping costs until an address is entered is now a block setting, and altering the API to show only local pickup options would not be possible. If it were done in the Store API and there were two Checkout blocks on the site the Store API would only return correct data for one of the blocks.
There was also a scenario where entering a complete address would instantly trigger a rate selection (when the rate radio buttons got rendered) and if the user was entering their address at that time, then the address returned by the API during the
selectShippingRateaction would be missing the field the user was editing (because that field was not pushed to the server yet) and that would update the form, thus deleting the user's currently entered text. To avoid this, theshipping_addressandbilling_addresskeys are removed from the response when updating the cart data following a shipping rate selection.This PR also updates the local pickup e2e tests. The changes made here are:
tests/utils/merchant.ts) and improve the DX of using these functions (i.e. theenableLocalPickupfunction also includes navigating to the settings page).Hide shipping costs until an address is enteredsetting correctly prevents rates from appearing until the address is fully entered.Testing
Automated Tests
User Facing Testing
WooCommerce -> Settings -> Shipping -> Local Pickup, enable Local Pickup and add a location.Hide shipping costs until an address is enteredoption.Default customer locationtoNo location by default.calculated with an addressHide shipping costs until an address is enteredin the editor and ensure the rates show as usual, even without a full address.WooCommerce Visibility
Performance Impact
Changelog