-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
…h the updated structure adopted for single product related blocks.
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: -1.13 kB (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! I have some doubts about the style. Pre-approving it.
assets/js/atomic/blocks/product-elements/add-to-cart-form/index.tsx
Outdated
Show resolved
Hide resolved
assets/js/atomic/blocks/product-elements/add-to-cart-form/style.scss
Outdated
Show resolved
Hide resolved
assets/js/atomic/blocks/product-elements/add-to-cart-form/style.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the changes & It looks good to me. Well done @nefeline 🚀
Thanks for the review, folks! Feedback addressed. @gigitux I left a question for you on #8482 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
While working on #8225 @gigitux made some changes that updated the structure of the
product-details
and thegallery
blocks. This PR updates theadd-to-cart-form
block to ensure the same structure is in place by:product-details
directory (Original discussion here).registerBlockSingleProductTemplate
made on Add Product Image Gallery #8235 )Testing
The test instructions here are identical to #8284 : no changes should be observed in the functionality of this block.
User Facing Testing
WooCommerce Visibility
Changelog