This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Single Product Details block #8225
Add Single Product Details block #8225
Changes from 23 commits
d46e480
e743ebe
f87de21
561f6f8
d07b9b5
9c90f71
eb0ce4a
22be4e9
2a4baad
8e05b71
f70ab0c
4ea37cb
ad70695
fd83c09
3661133
8a9196e
edcac21
528b9ce
0ba35e1
af09b77
93bcb28
7742ffe
96fab80
43dd558
85e6247
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The styles are now broken due to the latest changes to rename the block from
single-product-details
toproduct-details
. The following should do the trick:I also suggest renaming the class prefix from
wp-block
towc-block
so it is aligned with the standards we are using in other blocks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to avoid adding a custom class. We should use WP generated class (more context: p1675160559571929-slack-C02UBB1EPEF)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool, I missed that convo, thanks for sharing! I'll also go ahead and update #8284 with this prefix.
In case someone else comes across this convo: the reason for this decision was that for new blocks, it's a good idea not to introduce new classes, as block themes interact with blocks via theme.json.