-
Notifications
You must be signed in to change notification settings - Fork 219
Fix Markdown table in payment-method-integration.md #8158
Conversation
Hi @szepeviktor! That's a great contribution, thank you so much that you took a time to prepare it! 🙏 Usually, when preparing a PR, we use the standard template that shows up when opening the PR. We apply that to all the types of PRs, even the smallest ones. That allows us to have a better understanding of what PR contains and keep a better history of the changes. Having said that, I hope you don't mind, that I allowed myself to extend the description, so it follows the standard template. 🙌 At the same time it's so great you spotted the issue with the table and took action to fix that, we're grateful you did that! I'll make sure the branch is up-to-date and will do the final review when all the checks will pass. |
@kmanijak Yes, it was hard to fix the Markdown table. I ran out of energy for PR documentation. |
Hi @szepeviktor : thank you so much for your contribution! We are investigating why some of the required checks are failing for this PR. We will post an update here as soon as everything is a-ok. |
Thank you Patricia! |
Meanwhile it was fixed in 61370e6 |
Hi @szepeviktor ! Our sincere apologies: the reason why your work here took so long to be merged is because it sparked an important internal discussion regarding how to handle CI tests in forked repositories, considering some of them are failing by default due to authentication problems, as visible here. In the end, your contribution had an impact even more significant than updating the markdown on Your commit here was cherry-picked, the conflicts solved and merged on #8258 |
Description
Fix the incorrect formatting in the Payment Method Integration for the Checkout Block - table is not rendering correctly in the Props Fed to Payment Method Nodes section
This PR contains whitespace changes only.
Screenshots
Testing
Testing steps
trunk
: beforeWooCommerce Visibility