Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix Markdown table in payment-method-integration.md #8158

Closed
wants to merge 3 commits into from
Closed

Fix Markdown table in payment-method-integration.md #8158

wants to merge 3 commits into from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jan 11, 2023

Description

Fix the incorrect formatting in the Payment Method Integration for the Checkout Block - table is not rendering correctly in the Props Fed to Payment Method Nodes section

This PR contains whitespace changes only.

Screenshots

Before After
image . image

Testing

Testing steps

  • Before: check the table on trunk: before
  • After: check the table in this PR: after 😍
  • Do not include in the Testing Notes

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

@kmanijak kmanijak added the focus: documentation This issue is a request for better documentation. label Jan 13, 2023
@kmanijak
Copy link
Contributor

Hi @szepeviktor! That's a great contribution, thank you so much that you took a time to prepare it! 🙏

Usually, when preparing a PR, we use the standard template that shows up when opening the PR. We apply that to all the types of PRs, even the smallest ones. That allows us to have a better understanding of what PR contains and keep a better history of the changes. Having said that, I hope you don't mind, that I allowed myself to extend the description, so it follows the standard template. 🙌

At the same time it's so great you spotted the issue with the table and took action to fix that, we're grateful you did that!

I'll make sure the branch is up-to-date and will do the final review when all the checks will pass.

@szepeviktor
Copy link
Contributor Author

@kmanijak Yes, it was hard to fix the Markdown table. I ran out of energy for PR documentation.

@nefeline
Copy link
Contributor

Hi @szepeviktor : thank you so much for your contribution! We are investigating why some of the required checks are failing for this PR. We will post an update here as soon as everything is a-ok.

@szepeviktor
Copy link
Contributor Author

Thank you Patricia!

@szepeviktor
Copy link
Contributor Author

Meanwhile it was fixed in 61370e6

nefeline added a commit that referenced this pull request Mar 14, 2023
…bution #8158 (#8258)

* Fix Markdown table in payment-method-integration.md

* Update the hooks for eventRegistration

---------

Co-authored-by: Viktor Szépe <viktor@szepe.net>
Co-authored-by: kmanijak <karol.manijak@automattic.com>
@nefeline
Copy link
Contributor

Hi @szepeviktor ! Our sincere apologies: the reason why your work here took so long to be merged is because it sparked an important internal discussion regarding how to handle CI tests in forked repositories, considering some of them are failing by default due to authentication problems, as visible here. In the end, your contribution had an impact even more significant than updating the markdown on payment-method-integration.md: thanks again for your work!

Your commit here was cherry-picked, the conflicts solved and merged on #8258

@nefeline nefeline closed this Mar 14, 2023
@szepeviktor szepeviktor deleted the fix/md branch March 14, 2023 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: documentation This issue is a request for better documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants