-
Notifications
You must be signed in to change notification settings - Fork 221
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/store-notices/index.tsx
|
Size Change: +1.68 kB (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
0c09df4
to
3ae12ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, @albarin! I left some comments/questions inline, but most of them are minor suggestions.
@Aljullu Thanks for the review, I think I've addressed all your comments. Can you have another look? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments, this is testing great for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the notice don't have any styling in the editor, but I think that's because we are not loading some WC core CSS files in the editor, so probably not something we can fix on our repo, it might be worth creating a follow-up issue to investigate this.
I left one more comment inline about a CSS file which I think we can remove, now. Besides that, LGTM, good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some optional comments. This is LGTM so I'm pre-approving. Thank you so much @albarin for working on this.
Co-authored-by: Tung Du <dinhtungdu@gmail.com>
Co-authored-by: Tung Du <dinhtungdu@gmail.com>
The goal of this PR is to add the new
Store Notices
block as part of the blockifying the product archive template project.It uses the
woocommerce_output_all_notices()
function to render the notices on the front end.Fixes #8062
Testing
Automated Tests
User Facing Testing
Site Editor
>Browse all templates
and open theHeader
template.Store Notices
block in the Header.Store Notices
block. Make sure it only appears once.To trigger a notice:
My Account
>Account Details
, leave empty a required field, and save the form.Cart
, try to apply a coupon that doesn't exist.WooCommerce Visibility
Changelog