This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove page view tracking in favor of jetpack #12010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
senadir
commented
Dec 1, 2023
| @@ -81,6 +82,8 @@ function() { | |||
| // This is required to short circuit `show_shipping` from class-wc-cart.php - without it, that function | |||
| // returns based on the option's value in the DB and we can't override it any other way. | |||
| add_filter( 'option_woocommerce_shipping_cost_requires_address', array( $this, 'override_cost_requires_address_option' ) ); | |||
|
|
|||
| add_action( 'rest_pre_serve_request', array( $this, 'track_local_pickup' ), 10, 4 ); | |||
There was a problem hiding this comment.
This is not part of the page views, but was in that script, it's now moved.
senadir
commented
Dec 1, 2023
| @@ -663,7 +663,7 @@ private function create_customer_account( $user_email, $first_name, $last_name ) | |||
| 'first_name' => $first_name, | |||
| 'last_name' => $last_name, | |||
| 'role' => 'customer', | |||
| 'source' => 'store-api,', | |||
There was a problem hiding this comment.
This was a typo, it's now fixed to allow views in the other branch to work.
|
Size Change: -750 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
3 tasks
opr
approved these changes
Dec 1, 2023
wavvves
pushed a commit
that referenced
this pull request
Dec 1, 2023
wavvves
added a commit
that referenced
this pull request
Dec 5, 2023
* Empty commit for release pull request * Update feedback link (#11999) * Update Feedback link on Cart and Checkout blocks (#12006) * Update feedback link * Remove default url link, and make the param required * Updated readme.txt Updated versions Added testing steps * Remove page view tracking in favor of jetpack (#12010) * import checkbox from single place (#12015) * Revert "import checkbox from single place (#12015)" This reverts commit d952f8e. * Updated testing zip link --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com> Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all page view tracking since we moved them to Jetpack.
Testing Instructions
woocommerceanalytics_order_confirmation_view,woocommerceanalytics_cart_view,woocommerceanalytics_checkout_view.WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).