This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix styling of Classic Cart and Checkout Blocks on regular pages #11694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +23 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
tarunvijwani
previously requested changes
Nov 9, 2023
There was a problem hiding this comment.
Thank you for working on this, @mikejolley! I wasn't able to reproduce the issue on the trunk. Is it happening on a specific theme?
I have requested a change based on my observation. Please correct me if I'm missing anything.
nielslange
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Thanks for working on this, @mikejolley. I've successfully tested this PR and ran one failing E2E test, which now passed. Let's ⛴️ this fix. 🙌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When the classic shortcode block (classic cart or classic checkout variation) is used on a page that is not set as the main cart and checkout page, the styling is broken. This PR fixes this.
Why
The blocks can be inserted on any page, or the assigned page may change.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog