This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[PHP 8.1 Compatibility] Check That Data is Countable in SingleProductTemplateCompatibility Template #11670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
tjcafferkey
approved these changes
Nov 8, 2023
Ensure the data is countable before running `count()` on it to avoid a Fatal Error.
25908ac to
dc85ab9
Compare
|
This seems to have been fixed by @prettyboymp in #11473. Confirmed that the scan is no longer showing errors. Will close this out for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use
is_countable()before usingcount()on data in the ProductQuery block type.Fixes #11667
Why
Rector has reported issues with using
count()in places there could be potentially non-countable data which can result in a fatal error.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
/src/BlockTypes/ProductQuery.phpand confirm there is noCountOnNullRectororRenameFunctionRectorerror.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog