This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix products incorrectly marked as discounted #11386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +10 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
nielslange
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Thanks for working on this, @tarhi-saad. On the Cart and Checkout blocks, the change works as expected. However, I noticed that on the product page, the old price logic is still visible.
While it's obvious to us, that @woocommerce/rubik maintains the Cart and Checkout blocks, while @woocommerce/woo-fse maintains all other blocks, for external folks, this might not be obvious. They might be wondering why this PR only partially changes the logic of how we display discounted prices.
I wonder if we should get someone from @woocommerce/woo-fse involved, to ensure that we change the display logic of all discounted prices. Or if we should create a follow-up ticket for them and ensure that both PRs will land in the same release.
|
I think that it works as expected! The hook works on I tried with the storefront theme, and I noticed that the prices of the products don't change. Futhermore, I noticed this weired behavior with the Mini Cart:
Instead, with the new Mini Cart block, this behavior has been fixed: |
|
Before merging this PR, I would suggest adding E2E tests to catch future potential regression. It should not require a lot of time and it could help us in the long term. There is dedicated documentation that explains how testing filters and actions: https://github.com/woocommerce/woocommerce-blocks/blob/7403a5a4c2a23f1f5e94041e2ac1a7dde6dc8805/tests/e2e/mocks/custom-plugins/readme.md |
Right. I haven't thought about that. Thanks for pointing this out, @gigitux. |
nielslange
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
My previous comment was answered in #11386 (comment). Let's ⛴️ this change, @tarhi-saad.
|
Please
+1 on this. @tarhi-saad don't merge this without adding a test. Let's strive to add automated tests to all our bug fixes. |
tarhi-saad
commented
Oct 27, 2023
| } ) => { | ||
| await installPluginFromPHPFile( | ||
| `${ __dirname }/update-price-plugin.php` | ||
| ); |
There was a problem hiding this comment.
Hi, @gigitux! I followed the guidance from Testing WordPress actions and filters but didn't achieve the expected outcome. The custom plugin that's supposed to alter product prices in the Cart didn't seem to work; it showed the original prices instead. I tried debugging this issue yesterday without success. Could you help me in identifying any potential steps I might have overlooked?
There was a problem hiding this comment.
Hi, @tarhi-saad!
I tried to run the test, and the price is updated.
I don't think that it is related, but the only change that I made was to add the suffix .side_effects. This is necessary because the filter could impact other tests (Mini Cart - for example), so it has to be run NOT in parallel.
f684f69 to
b8c504d
Compare
We don't want to mark a product as having a discount when price includes additional costs
c75deb2 to
c1c031f
Compare
|
All tests are passing! I'll merge this PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We are incorrectly displaying some products as discounted when their price is updated to add some extra cost.
Fixes #10433
Why
Revised the
isDiscountedlogic. Now, the discount is applied only when the new price is lower than theregularPrice, rather than just being different.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Order Summarysection, confirm that the discount label is only visible next to the discounted product.Order summarysection, Confirm that both products reflect the new price (50) and neither displays a discount label.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog