This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 220
Store Customization > Ensure the Just Arrived Full Hero pattern can have an AI selected image assigned to it #11159
Merged
nefeline
merged 16 commits into
trunk
from
fix/ensure-ai-generated-image-is-displayed-on-just-arrived-pattern
Oct 6, 2023
Merged
Store Customization > Ensure the Just Arrived Full Hero pattern can have an AI selected image assigned to it #11159
nefeline
merged 16 commits into
trunk
from
fix/ensure-ai-generated-image-is-displayed-on-just-arrived-pattern
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e assigned to it and update the content assignment.
woocommercebot
requested review from
a team and
danieldudzic
and removed request for
a team
October 6, 2023 08:02
nefeline
added
focus: patterns
WooCommerce patterns
type: bug
The issue/PR concerns a confirmed bug.
labels
Oct 6, 2023
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
albarin
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
…image-is-displayed-on-just-arrived-pattern
…on-just-arrived-pattern
nefeline
deleted the
fix/ensure-ai-generated-image-is-displayed-on-just-arrived-pattern
branch
October 6, 2023 11:17
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the Just Arrived Full Hero pattern to ensure that:
Why
These changes are required to ensure this pattern can work as expected within the Pattern Assembler and is correctly displayed independent of the images assigned to it by AI.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
PS: the background image doesn't necessarily have to match what is displayed in the screenshot below; those are dynamically changed depending on the business description.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog