This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Store Customization > Homepage Template 2: Review layout and spacing in between patterns #11129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +6 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
nefeline
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Hey @albarin ! Based on the outcome of the decision made yesterday (ref. p1696423213570069-slack-C02FL3X7KR6 ) , the 1:1 Image 4-Column Product Row pattern is being replaced with the Product Collection 4 Columns and the Minimal 5-Column Product Row pattern is being replaced with Product Collection 5 Columns. These patterns are essentially the same as the pre-exsiting ones, the only difference is that the new Product Collection block is being used to power them rather than the pre-existing Products (Beta). See: #11134
Could you please port over the changes you did here to the new patterns as soon as they are merged?
d67e028 to
7fd91d7
Compare
@nefeline Thanks! I updated them, could you have another look? 🙏 |
|
Thanks @albarin ! By comparing the templates with our patterns, I think we can do some extra fine-tuning here, including:
|
Hey @nefeline, I agree, I will remove the pagination and placeholder for all the |
Merged
13 tasks
nefeline
approved these changes
Oct 5, 2023
Merged
13 tasks
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR:
Product Collection 4 Columns,Product Collection 5 Columns, andTestimonials 3 Columnspatterns.Fixes #11089
Why
To adapt to the designs shown on #11089.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
1:1 image 4-column products rowcorresponds toProduct Collection 4 Columns.Minimal 5-column products rowcorresponds toProduct Collection 5 Columns.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog