This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Store Customization > Wireframe and adjust width for the Just Arrived Full Hero pattern #11115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ust the width to wide.
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
|
Hey @nefeline, I'm seeing the text in black, not white (I'm using TT3 with the default styles). Also, I think there's an extra space before the |
|
Hey @albarin ! Good catch ref. the space before the title: fixed on 02b4b9e
The color change is actually controlled by GB: if you add an image that is dark enough, it should automatically change it to white: Screen.Recording.2023-10-04.at.12.41.16.movCould you perhaps try with a darker image? |
|
Oh cool, I didn't know that! Thanks for the fix ✅ |
albarin
approved these changes
Oct 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make a few adjustments to the Just Arrived Full Hero pattern to ensure that:
Fixes #11114
Why
These adjustments are required to match the designs for the templates within the Patterns Assembler.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog