This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Store Customization > Add the Featured Category Cover Image pattern #11109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
tjcafferkey
reviewed
Oct 3, 2023
| "titles": [ | ||
| { | ||
| "default": "100% natural denim", | ||
| "ai_prompt": "A description for a product" |
There was a problem hiding this comment.
Just a question on the prompts in general, do we ever specify a text limit on the values returned to ensure they don't break designs?
There was a problem hiding this comment.
Great question: we are still fine-tuning the prompts to AI as part of a separate task :)
tjcafferkey
approved these changes
Oct 3, 2023
thealexandrelara
approved these changes
Oct 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The Featured Category Cover Image pattern was originally removed on #10239, but we need to reintroduce it as it is a requirement to compose the homepage templates for the Pattern Assembler as designed on Mrk6SERPZ4KrFHSjM0a8TK-fi-1406_127404 and we can't rely exclusively on blocks for having AI-generated content.
This is a wireframed pattern: in other words, it doesn't have any opinionated styles regarding colors for fonts or backgrounds.
Fixes #11107
Why
This pattern is required to compose two different templates within the Patterns Assembler.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog