This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add local pickup tracking #10841
Merged
Add local pickup tracking #10841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/base/context/hooks/cart/test/use-store-cart.js
assets/js/base/context/hooks/collections/test/use-collection.js assets/js/base/context/hooks/test/use-query-state.js assets/js/base/hocs/test/with-reviews.js assets/js/base/hooks/test/use-previous.js assets/js/base/hooks/test/use-shallow-equal.js assets/js/blocks/classic-template/index.tsx assets/js/blocks/price-filter/test/use-price-constraints.js assets/js/data/checkout/thunks.ts assets/js/data/payment/thunks.ts assets/js/editor-components/template-notice/index.tsx assets/js/extensions/jetpack/woocommerce-analytics/index.ts assets/js/hocs/test/with-categories.js assets/js/hocs/test/with-category.js assets/js/hocs/test/with-product-variations.js assets/js/hocs/test/with-product.js assets/js/hocs/test/with-searched-products.js assets/js/templates/revert-button/index.tsx node_modules/@wordpress/core-data/src/entities.ts |
|
Size Change: +957 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
opr
suggested changes
Sep 7, 2023
There was a problem hiding this comment.
I think we need to move
$this->container->get( JetpackWooCommerceAnalytics::class )->init();
from this line in Bootstrap.php outside of the if ( ! $is_rest ) condition, because currently pressing save does not trigger the event.
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
|
@opr We can gate loading the assets file behind a |
Sounds like a good idea, let me know when you need a new review! |
e11b507 to
3c26b8c
Compare
opr
approved these changes
Sep 19, 2023
Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds PHP side tracking to Local Pickup save action, it will push the whole object everytime being saved.
What
Closes woocommerce/woocommerce#37699
Closes #9731
Testing