This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
E2E: Improve the setup script #10611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
gigitux
reviewed
Aug 16, 2023
| bash $script_dir/attributes.sh | ||
|
|
||
| # Run all scripts in parallel at maximum 10 at a time | ||
| find $script_dir/parallel/*.sh -maxdepth 1 -type f | xargs -P10 -n1 bash |
gigitux
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Thanks @dinhtungdu, for your effort in improving E2E test infrastructure! Great work and LGTM!
I just added a comment because I'm not sure that all products page is necessary, but I'm pre-approving the PR.
Comment on lines
5
to
11
| wp post create \ | ||
| --menu_order=0 \ | ||
| --post_type=page \ | ||
| --post_status=publish \ | ||
| --post_author=1 \ | ||
| --post_title='All Products block' \ | ||
| ${script_dir}/all-products.html |
There was a problem hiding this comment.
I'm not sure. In this PR, I'm trying to convert the old script to the new one only. Searching our tests, look like we aren't using that page anywhere.
There was a problem hiding this comment.
@gigitux and @dinhtungdu In https://github.com/nielslange/woo-test-environment, the All Products block is used for the shop page, see https://github.com/nielslange/woo-test-environment/blob/5cfa23af4a4aa426f71b7a626ad8a3786f722ccb/command.php#L212-L216
I'll try to review this PR later today and will double-check if the All Products block is needed or not.
There was a problem hiding this comment.
@gigitux and @dinhtungdu These are the only places, where we interact with the All Products block:
As far as I can tell, the page All Products block is not loaded directly anywhere and can safely be removed.
There was a problem hiding this comment.
I removed the All Products block page in 4473ffc
nielslange
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Thanks for working on this, @dinhtungdu. The environment starts indeed much faster. Well done that you separated the setup steps into various shell scripts. 👏
Comment on lines
5
to
11
| wp post create \ | ||
| --menu_order=0 \ | ||
| --post_type=page \ | ||
| --post_status=publish \ | ||
| --post_author=1 \ | ||
| --post_title='All Products block' \ | ||
| ${script_dir}/all-products.html |
There was a problem hiding this comment.
@gigitux and @dinhtungdu These are the only places, where we interact with the All Products block:
As far as I can tell, the page All Products block is not loaded directly anywhere and can safely be removed.
13 tasks
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR are trying to some related issues at once. I'm sorry about that. In this PR:
txttohtmlto use syntax highlighting in the editor.tests/e2e/bin/posts/and and the setup script will pick it automatically.tests/e2e/bin/scripts/and the setup script will pick it automatically.By introducing all of those changes above, we're able to cut the time running
npm run evn:restartdown to49son my machine, while the previous setup time is2m41sin my recent test.On CI, the improvement is also notable.
Fixes #9646, fixes #10594
Testing
Automated Tests
User Facing Testing
Ensure the Playwright tests are still passing.
WooCommerce Visibility
Performance Impact
Improve the speed of the provision process for e2e environment.
Changelog
N/a