Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

PHP Unit Tests for Cart/Checkout/ Order Received Templates #9290

Closed
Tracked by #9288
wavvves opened this issue Apr 28, 2023 · 2 comments
Closed
Tracked by #9288

PHP Unit Tests for Cart/Checkout/ Order Received Templates #9290

wavvves opened this issue Apr 28, 2023 · 2 comments
Assignees

Comments

@wavvves
Copy link
Contributor

wavvves commented Apr 28, 2023

Part of Epic: Cart/Checkout/Order Received Templates #9288

PHP Unit Tests. Blocked by #9289

Should be merged to epic's main branch.

Note: This issue is detached from the code it is testing as we already have POCs for the mentioned templates.

@wavvves wavvves added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Apr 28, 2023
@wavvves wavvves changed the title Tests for Cart/Checkout/ Order Received FSE Templates Tests for Cart/Checkout/ Order Received Templates May 5, 2023
@wavvves wavvves self-assigned this May 23, 2023
@wavvves wavvves removed the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label May 30, 2023
@wavvves wavvves changed the title Tests for Cart/Checkout/ Order Received Templates PHP Unit Tests for Cart/Checkout/ Order Received Templates Jun 16, 2023
@mikejolley
Copy link
Member

mikejolley commented Jun 20, 2023

@wavvves there doesn't seem to be anything special on the PHP side that would justify test coverage. Did you have anything in mind for this task?

@wavvves
Copy link
Contributor Author

wavvves commented Jun 28, 2023

@mikejolley you are probably right, I was checking for successful template registration, but it does not make much sense to do that individually. Maybe in the future if we register templates with a foreach maybe it would make sense to check the list against properly registered templates. I'll close this, and look into your E2E PR that will cover the changes properly 👍🏼

@wavvves wavvves closed this as completed Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants