Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Refactor template related code #9289

Closed
Tracked by #9288
wavvves opened this issue Apr 28, 2023 · 3 comments
Closed
Tracked by #9288

Refactor template related code #9289

wavvves opened this issue Apr 28, 2023 · 3 comments
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. skip-changelog PRs that you don't want to appear in the changelog. status: blocker Used on issues or pulls that block work from being released. type: refactor The issue/PR is related to refactoring. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@wavvves
Copy link
Contributor

wavvves commented Apr 28, 2023 •
edited
Loading

Part of Epic: Cart/Checkout/Order Received Templates #9288

Our current template-related code contains duplication, and since it has been used in several use case templates now, it can be refactored for simplification purposes.

We do not currently have unit testing for it, and this issue must be resolved before, as it can drastically improve the dev experience writing tests.

Acceptance criteria is not set. Instead, we should limit the amount of time spent to one day and implement the improvements possible within the timeframe.

Note: It should be merged into trunk to avoid future conflicts.
@wavvves wavvves added the type: technical debt This issue/PR represents/solves the technical debt of the project. label Apr 28, 2023
@wavvves wavvves self-assigned this Apr 28, 2023
This was referenced Apr 28, 2023
Closed
Closed
@wavvves wavvves added status: blocker Used on issues or pulls that block work from being released. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: refactor The issue/PR is related to refactoring. skip-changelog PRs that you don't want to appear in the changelog. labels Apr 28, 2023
@wavvves wavvves changed the title Refactor FSE template related code Refactor template related code May 5, 2023
@mikejolley
Copy link
Member

I'll take this one.

@mikejolley
Copy link
Member

Making a note because there will be a followup needed; we use CHECKOUT_PAGE_ID etc across the codebase. When moving from pages to checkout endpoints, this all needs to be replaced.

@mikejolley mikejolley mentioned this issue May 9, 2023
Merged
@wavvves wavvves mentioned this issue May 10, 2023
Closed
@wavvves
Copy link
Contributor Author

wavvves commented May 12, 2023

Resolved by #9411. This will find its way into the project branch via #9426, as it depends on it.

@wavvves wavvves closed this as completed May 12, 2023
@wavvves wavvves mentioned this issue Jun 16, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. skip-changelog PRs that you don't want to appear in the changelog. status: blocker Used on issues or pulls that block work from being released. type: refactor The issue/PR is related to refactoring. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikejolley @wavvves