Wait for canvas before enabling Apply Filters button

woocommerce · Apr 2, 2023 · ab5e5b8 · ab5e5b8
1 parent c025afa
commit ab5e5b8
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 17 deletions.
diff --git a/tests/e2e/specs/shopper/filter-products-by-attribute.test.ts b/tests/e2e/specs/shopper/filter-products-by-attribute.test.ts
@@ -9,7 +9,6 @@ import {
 	switchUserToAdmin,
 	publishPost,
 } from '@wordpress/e2e-test-utils';
-import { selectBlockByName } from '@woocommerce/blocks-test-utils';
 
 /**
  * Internal dependencies
@@ -20,6 +19,7 @@ import {
 	saveTemplate,
 	useTheme,
 	waitForAllProductsBlockLoaded,
+	waitForCanvas,
 	insertAllProductsBlock,
 	enableApplyFiltersButton,
 } from '../../utils';
@@ -185,9 +185,8 @@ describe( `${ block.name } Block`, () => {
 				postId: productCatalogTemplateId,
 			} );
 
-			await selectBlockByName( block.slug );
-
-			await enableApplyFiltersButton();
+			await waitForCanvas();
+			await enableApplyFiltersButton( block.slug );
 
 			await saveTemplate();
 			await goToShopPage();
@@ -300,9 +299,9 @@ describe( `${ block.name } Block`, () => {
 
 		it( 'should refresh the page only if the user clicks on button', async () => {
 			await page.goto( editorPageUrl );
-			await selectBlockByName( block.slug );
 
-			await enableApplyFiltersButton();
+			await waitForCanvas();
+			await enableApplyFiltersButton( block.slug );
 
 			await saveOrPublish();
 			await page.goto( frontedPageUrl );

diff --git a/tests/e2e/specs/shopper/filter-products-by-price.test.ts b/tests/e2e/specs/shopper/filter-products-by-price.test.ts
@@ -8,7 +8,6 @@ import {
 	switchUserToAdmin,
 	publishPost,
 } from '@wordpress/e2e-test-utils';
-import { selectBlockByName } from '@woocommerce/blocks-test-utils';
 
 /**
  * Internal dependencies
@@ -18,6 +17,7 @@ import {
 	goToTemplateEditor,
 	saveTemplate,
 	useTheme,
+	waitForCanvas,
 	waitForAllProductsBlockLoaded,
 	insertAllProductsBlock,
 	enableApplyFiltersButton,
@@ -179,9 +179,8 @@ describe( `${ block.name } Block`, () => {
 				postId: productCatalogTemplateId,
 			} );
 
-			await selectBlockByName( block.slug );
-
-			await enableApplyFiltersButton();
+			await waitForCanvas();
+			await enableApplyFiltersButton( block.slug );
 
 			await saveTemplate();
 			await goToShopPage();
@@ -284,8 +283,8 @@ describe( `${ block.name } Block`, () => {
 		it( 'should refresh the page only if the user click on button', async () => {
 			await page.goto( editorPageUrl );
 
-			await selectBlockByName( block.slug );
-			await enableApplyFiltersButton();
+			await waitForCanvas();
+			await enableApplyFiltersButton( block.slug );
 
 			await saveOrPublish();
 			await page.goto( frontedPageUrl );

diff --git a/tests/e2e/specs/shopper/filter-products-by-rating.test.ts b/tests/e2e/specs/shopper/filter-products-by-rating.test.ts
@@ -158,8 +158,7 @@ describe( `${ block.name } Block`, () => {
 			} );
 
 			await waitForCanvas();
-			await selectBlockByName( block.slug );
-			await enableApplyFiltersButton();
+			await enableApplyFiltersButton( block.slug );
 
 			await saveTemplate();
 			await goToShopPage();

diff --git a/tests/e2e/specs/shopper/filter-products-by-stock.test.ts b/tests/e2e/specs/shopper/filter-products-by-stock.test.ts
@@ -164,8 +164,7 @@ describe( `${ block.name } Block`, () => {
 			} );
 
 			await waitForCanvas();
-			await selectBlockByName( block.slug );
-			await enableApplyFiltersButton();
+			await enableApplyFiltersButton( block.slug );
 
 			await saveTemplate();
 			await goToShopPage();

diff --git a/tests/e2e/utils.js b/tests/e2e/utils.js
@@ -18,6 +18,7 @@ import {
 } from '@wordpress/e2e-test-utils';
 import { addQueryArgs } from '@wordpress/url';
 import { WP_ADMIN_DASHBOARD } from '@woocommerce/e2e-utils';
+import { selectBlockByName } from '@woocommerce/blocks-test-utils';
 import fs from 'fs';
 
 /**
@@ -504,7 +505,8 @@ export const insertAllProductsBlock = async () => {
 	insertButton?.click();
 };
 
-export const enableApplyFiltersButton = async () => {
+export const enableApplyFiltersButton = async ( blockSlug ) => {
+	await selectBlockByName( blockSlug );
 	await ensureSidebarOpened();
 	await switchBlockInspectorTab( 'Settings' );