Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shipping labels survey #13319

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 15, 2025

Part of: #13012

Description

This removes shipping labels survey from the order detail screen.
Rationale: pe5sF9-3GX-p2

Steps to reproduce

  1. Open the detail of an order that shows a feedback banner on trunk branch. (You can use the order 530 on the IPP testing site that mentioned here, P91TBi-bVe-p2)
  2. Verify that there isn't a feedback banner.

The tests that have been performed

Steps above

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the feature: send feedback Related to the in-app feedback / survey option in app settings. label Jan 15, 2025
@irfano irfano added this to the 21.5 milestone Jan 15, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 15, 2025

1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@irfano irfano added the category: tracks Related to analytics, including Tracks Events. label Jan 15, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 15, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit1adf8b6
Direct Downloadwoocommerce-wear-prototype-build-pr13319-1adf8b6.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 15, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit1adf8b6
Direct Downloadwoocommerce-prototype-build-pr13319-1adf8b6.apk

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.10%. Comparing base (60fe1f8) to head (1adf8b6).
Report is 18 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13319      +/-   ##
============================================
- Coverage     41.10%   41.10%   -0.01%     
  Complexity     6420     6420              
============================================
  Files          1321     1321              
  Lines         77177    77173       -4     
  Branches      10644    10645       +1     
============================================
- Hits          31721    31719       -2     
+ Misses        42646    42644       -2     
  Partials       2810     2810              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JorgeMucientes JorgeMucientes self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: send feedback Related to the in-app feedback / survey option in app settings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants