[Dependency Cache] Remove Restore Cache CI Hook #13288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this hook present, every build and its within jobs are all restoring the dependency cache, even when this is not really needed, and as such, potentially, unnecessarily delaying some jobs, while also consuming unnecessary resources (downloading from s3, (un)compressing, etc). FYI: It is better to use 'restore_gradle_dependency_cache' only on those jobs that could really benefit from it. PS: Also, based on the current state of things, with the dependency cache save/restore mechanism being stale, this 'restore_gradle_dependency_cache' command is not working as expected. No cache entry is found for 'GRADLE_DEPENDENCY_CACHE' is being output on every build/job that runs on an 'android' agent, plus an this 'GRADLE_RO_DEP_CACHE: unbound variable' is being output on every build/job that runs on another agent (like the 'linter' agent).
8 tasks
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
wzieba
approved these changes
Jan 10, 2025
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Thread: paaHJt-7CE-p2
(Softly) Required By: a8c-ci-toolkit#135
Description
This PR removes the CI
pre-commandhook that was responsible to triggerrestore_gradle_dependency_cache.With this hook present, every build and its within jobs are all restoring the dependency cache, even when this is not really needed, and as such, potentially, unnecessarily delaying some jobs, while also consuming unnecessary resources (downloading from s3, (un)compressing, etc).
FYI: It is better to use
restore_gradle_dependency_cacheonly on those jobs that could really benefit from it.PS: Also, based on the current state of things, with the dependency cache save/restore mechanism being stale, this
restore_gradle_dependency_cachecommand is not working as expected. No cache entry is found forGRADLE_DEPENDENCY_CACHEis being output on every build/job that runs on anandroidagent, plus an thisGRADLE_RO_DEP_CACHE: unbound variableis being output on every build/job that runs on another agent (like thelinteragent).Testing information
Just verify that all the CI checks are successful.
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:
N/A