Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android SDK] Update compile SDK to 35 #13271

Open
wants to merge 35 commits into
base: trunk
Choose a base branch
from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Jan 9, 2025

Closes: #13269

Description

The PR updates compile SDK version to 35 and brings the changes necessary to do so

There are a few of APIs that got deprecated:

  • Window.statusBarColor
  • Window.navigationBarColor
    Therefore there are changes related to it in WCModalBottomSheetLayout but they were reviewed already - [Android SDK update] Bottom sheet fixes #13285, so feel free to ignore those changes in the review

The changes in the WooPOS are done by tweaking the theme. Validate that there are no visual changes regarding the colors

Testing information

Green CI should be enough, but just for sake of safety check Blaze related functionality and it's bottoms sheets as well as Woo POS

The tests that have been performed

Above

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov linked an issue Jan 9, 2025 that may be closed by this pull request
@kidinov kidinov marked this pull request as draft January 9, 2025 10:39
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 9, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 9, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit542c8f4
Direct Downloadwoocommerce-wear-prototype-build-pr13271-542c8f4.apk

@kidinov kidinov changed the title [Android SDK] update min sdk to 35 [Android SDK] Update min SDK to 35 Jan 9, 2025
@kidinov kidinov changed the title [Android SDK] Update min SDK to 35 [Android SDK] Update compile SDK to 35 Jan 10, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 10, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit542c8f4
Direct Downloadwoocommerce-prototype-build-pr13271-542c8f4.apk

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 93 lines in your changes missing coverage. Please review.

Project coverage is 41.09%. Comparing base (3222339) to head (542c8f4).
Report is 33 commits behind head on trunk.

Files with missing lines Patch % Lines
...d/ui/compose/component/WCModalBottomSheetLayout.kt 0.00% 85 Missing ⚠️
...paignCreationAdDestinationParametersBottomSheet.kt 0.00% 5 Missing ⚠️
...main/kotlin/com/woocommerce/android/model/Order.kt 0.00% 0 Missing and 1 partial ⚠️
...orders/wooshippinglabels/address/AddressSection.kt 0.00% 1 Missing ⚠️
...mmerce/android/util/ApplicationLifecycleMonitor.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13271      +/-   ##
============================================
- Coverage     41.10%   41.09%   -0.01%     
+ Complexity     6421     6420       -1     
============================================
  Files          1321     1320       -1     
  Lines         77177    77193      +16     
  Branches      10643    10644       +1     
============================================
- Hits          31722    31721       -1     
- Misses        42646    42662      +16     
- Partials       2809     2810       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kidinov kidinov requested a review from samiuelson January 15, 2025 14:29
@kidinov kidinov added this to the 21.5 milestone Jan 15, 2025
@kidinov kidinov marked this pull request as ready for review January 15, 2025 14:30
@samiuelson samiuelson self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android SDK] Update compile SDK to 35
6 participants