Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump androidx.activity:activity-ktx from 1.8.0 to 1.9.3 #12801

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Bump androidx.activity:activity-ktx from 1.8.0 to 1.9.3 #12801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8955174
Bump androidx.activity:activity-ktx from 1.8.0 to 1.9.3
dependabot[bot] Oct 18, 2024
f8ede3f
Merge branch 'trunk' into dependabot/gradle/androidx.activity-activit…
JorgeMucientes Dec 3, 2024
292fd06
Removes Intent nullability from Activity's onNewIntent
JorgeMucientes Dec 3, 2024
260f7ca
Remove activity-ktx as it is now completely empty dependency
JorgeMucientes Dec 3, 2024
38f34d6
Merge branch 'trunk' into dependabot/gradle/androidx.activity-activit…
JorgeMucientes Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion WooCommerce/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,6 @@ dependencies {

// ViewModel and LiveData
implementation(libs.androidx.fragment.ktx)
implementation(libs.androidx.activity.ktx)
implementation(libs.androidx.lifecycle.viewmodel.savedstate)
implementation(libs.androidx.lifecycle.process)

Expand Down
2 changes: 1 addition & 1 deletion WooCommerce/src/main/kotlin/com/woocommerce/android/ui/main/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ class MainActivity :
super.onPause()
}

override fun onNewIntent(intent: Intent?) {
override fun onNewIntent(intent: Intent) {
super.onNewIntent(intent)

// Verify authenticated session
Expand Down
3 changes: 1 addition & 2 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ agp = '8.5.1'
android-billingclient = '5.0.0'
android-desugar = '2.0.4'
android-security-lint = '1.0.1'
androidx-activity = '1.8.0'
androidx-activity = '1.9.3'
androidx-appcompat = '1.4.2'
androidx-arch-core = '2.1.0'
androidx-browser = '1.5.0'
Expand Down Expand Up @@ -98,7 +98,6 @@ android-billingclient-ktx = { group = "com.android.billingclient", name = "billi
android-desugar = { group = "com.android.tools", name = "desugar_jdk_libs", version.ref = "android-desugar" }
android-security-lint = { group = "com.android.security.lint", name = "lint", version.ref = "android-security-lint" }
androidx-activity-compose = { group = "androidx.activity", name = "activity-compose" }
androidx-activity-ktx = { group = "androidx.activity", name = "activity-ktx", version.ref = "androidx-activity" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

activity-ktx is now an empty dependency since all the code in android.activity was migrated to Kotlin when updating to version 1.9.0. More details here:

The remainder of the Activity APIs have been rewritten in Kotlin and all extensions previously available in activity-ktx have been moved to activity. activity-ktx is now completely empty.

androidx-appcompat = { group = "androidx.appcompat", name = "appcompat", version.ref = "androidx-appcompat" }
androidx-arch-core-testing = { group = "androidx.arch.core", name = "core-testing", version.ref = "androidx-arch-core" }
androidx-browser = { group = "androidx.browser", name = "browser", version.ref = "androidx-browser" }
Expand Down
Loading