Bump Aztec to 2.1.4
#12316
Merged
Bump Aztec to 2.1.4
#12316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust artifact coordinates, use `design_bottom_sheet` from `material` library (instead of referencing to aztec's file, which I'm guessing was added by a mistake)
wzieba
commented
Aug 13, 2024
| @@ -39,7 +39,7 @@ open class WCBottomSheetDialogFragment : BottomSheetDialogFragment { | |||
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | |||
| dialog?.setOnShowListener { | |||
| val dialog = it as BottomSheetDialog | |||
| dialog.findViewById<View>(org.wordpress.aztec.R.id.design_bottom_sheet)?.let { sheet -> | |||
| dialog.findViewById<View>(com.google.android.material.R.id.design_bottom_sheet)?.let { sheet -> | |||
There was a problem hiding this comment.
Referencing to org.wordpress.aztec was added in this commit: 4057a88 which looks like a mistake/unwanted changed rather than specifically reference design_bottom_sheet (3rd party xml file) from Aztec library.
There was a problem hiding this comment.
Makes sense, thanks for updating it! 🥇
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #12316 +/- ##
=========================================
Coverage 40.06% 40.06%
Complexity 5600 5600
=========================================
Files 1220 1220
Lines 69316 69316
Branches 9513 9513
=========================================
Hits 27771 27771
Misses 39011 39011
Partials 2534 2534 ☔ View full report in Codecov by Sentry. |
|
Found 1 violations: The PR caused the following dependency changes:expand
-+--- com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.45
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.11 -> 1.9.25 (*)
-| +--- org.ccil.cowan.tagsoup:tagsoup:1.2.1
-| +--- org.jsoup:jsoup:1.11.3
-| +--- androidx.legacy:legacy-support-v4:1.0.0
-| | +--- androidx.core:core:1.0.0 -> 1.13.1 (*)
-| | +--- androidx.media:media:1.0.0
-| | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
-| | | +--- androidx.core:core:1.0.0 -> 1.13.1 (*)
-| | | \--- androidx.versionedparcelable:versionedparcelable:1.0.0 -> 1.1.1 (*)
-| | +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
-| | +--- androidx.legacy:legacy-support-core-ui:1.0.0
-| | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
-| | | +--- androidx.core:core:1.0.0 -> 1.13.1 (*)
-| | | +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
-| | | +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
-| | | +--- androidx.viewpager:viewpager:1.0.0 (*)
-| | | +--- androidx.coordinatorlayout:coordinatorlayout:1.0.0 -> 1.1.0 (*)
-| | | +--- androidx.drawerlayout:drawerlayout:1.0.0 -> 1.1.1 (*)
-| | | +--- androidx.slidingpanelayout:slidingpanelayout:1.0.0 -> 1.2.0 (*)
-| | | +--- androidx.interpolator:interpolator:1.0.0 (*)
-| | | +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-| | | +--- androidx.asynclayoutinflater:asynclayoutinflater:1.0.0
-| | | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
-| | | | \--- androidx.core:core:1.0.0 -> 1.13.1 (*)
-| | | \--- androidx.cursoradapter:cursoradapter:1.0.0 (*)
-| | \--- androidx.fragment:fragment:1.0.0 -> 1.8.2 (*)
-| +--- com.google.android.material:material:1.0.0 -> 1.12.0 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.1.0 -> 1.8.1 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.1.0 -> 1.8.1 (*)
-| \--- org.apache.commons:commons-lang3:3.8.1 -> 3.12.0
-\--- com.github.wordpress-mobile.WordPress-Aztec-Android:glide-loader:v1.3.45
- +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.11 -> 1.9.25 (*)
- +--- com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.45 (*)
- \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
++--- org.wordpress:aztec:v2.1.4
+| +--- org.ccil.cowan.tagsoup:tagsoup:1.2.1
+| +--- org.jsoup:jsoup:1.15.3
+| +--- androidx.legacy:legacy-support-v4:1.0.0
+| | +--- androidx.core:core:1.0.0 -> 1.13.1 (*)
+| | +--- androidx.media:media:1.0.0
+| | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
+| | | +--- androidx.core:core:1.0.0 -> 1.13.1 (*)
+| | | \--- androidx.versionedparcelable:versionedparcelable:1.0.0 -> 1.1.1 (*)
+| | +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
+| | +--- androidx.legacy:legacy-support-core-ui:1.0.0
+| | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
+| | | +--- androidx.core:core:1.0.0 -> 1.13.1 (*)
+| | | +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
+| | | +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
+| | | +--- androidx.viewpager:viewpager:1.0.0 (*)
+| | | +--- androidx.coordinatorlayout:coordinatorlayout:1.0.0 -> 1.1.0 (*)
+| | | +--- androidx.drawerlayout:drawerlayout:1.0.0 -> 1.1.1 (*)
+| | | +--- androidx.slidingpanelayout:slidingpanelayout:1.0.0 -> 1.2.0 (*)
+| | | +--- androidx.interpolator:interpolator:1.0.0 (*)
+| | | +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+| | | +--- androidx.asynclayoutinflater:asynclayoutinflater:1.0.0
+| | | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
+| | | | \--- androidx.core:core:1.0.0 -> 1.13.1 (*)
+| | | \--- androidx.cursoradapter:cursoradapter:1.0.0 (*)
+| | \--- androidx.fragment:fragment:1.0.0 -> 1.8.2 (*)
+| +--- com.google.android.material:material:1.0.0 -> 1.12.0 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.8.1 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.8.1 (*)
+| +--- org.apache.commons:commons-lang3:3.8.1 -> 3.12.0
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 1.9.25 (*)
+\--- org.wordpress.aztec:glide-loader:v2.1.4
+ +--- org.wordpress:aztec:v2.1.4 (*)
+ +--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 1.9.25 (*)
Please review and act accordingly
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/woocommerce/woocommerce-android/security/dependabot/91
Description
This PR bumps Aztec to
2.1.4to address vulnerabilities of transitive dependencies.Testing information
Open editor (e.g. product description) and perform a few basic text edit operations.
I have considered adding unit tests for this change. If I decided not to add them, I have provided a brief explanation below (optional):RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.