Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Await profile items update in skip #4471

Merged
merged 1 commit into from
May 29, 2020
Merged

Await profile items update in skip #4471

merged 1 commit into from
May 29, 2020

Conversation

joshuatf
Copy link
Contributor

Fixes #4467

Fixes the broken skip button on the benefits page.

This was occurring because updateProfileItems now returns a promise so the await that was previously broken began working.

This is part of the problem described in #2959. The current logic is still messy, #2959 can finally be resolved once #4144 is merged in. 🎉

Detailed test instructions:

  1. Disable Jetpack and/or WCS.
  2. Enable the profiler and visit the last step.
  3. Attempt to continue by skipping with "No thanks"
  4. Reset the profiler.
  5. Attempt to continue by installing plugins with "Yes please"

@joshuatf joshuatf added type: bug The issue is a confirmed bug. [Status] Needs Review priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. labels May 29, 2020
@joshuatf joshuatf requested a review from a team May 29, 2020 10:08
@joshuatf joshuatf self-assigned this May 29, 2020
Copy link
Contributor

@jeffstieler jeffstieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and this tested well. :shipit:

@joshuatf joshuatf merged commit a2237a0 into master May 29, 2020
@joshuatf joshuatf deleted the fix/4467 branch May 29, 2020 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OBW broken when selecting "no thanks" on Benefits step
2 participants