This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Add List and Link components to Storybook #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatf
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Nice job, @mattsherman! Code looks solid and great to see some new additions to storybook. 🚢
| @@ -20,6 +31,12 @@ module.exports = ( { config: storybookConfig } ) => { | |||
|
|
|||
| storybookConfig.resolve.alias = wcAdminWebpackConfig.resolve.alias; | |||
|
|
|||
| wcAdminPackages.forEach( ( name ) => { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the List and Link components to Storybook. It also, by necessity, updates the Storybook webpack configuration to resolve the WooCommerce Admin packages, so that common components are correctly in Storybook.
There are no changes to the actual components in this PR.
This PR is part of the groundwork for creating a QuickLinks component for #4082, which will make use of the List and Link components.
Screenshots
Detailed test instructions:
npm run storybookhttp://localhost:6007/in your browser