Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MC setup flow to have four steps #914

Merged
merged 3 commits into from
Aug 2, 2021

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

Partial of #863

  • Add the fourth step page (layout only) for MC setup flow
  • Change values of MC steps to string type and add the fourth step key/value
  • Change MC setup flow to have four steps

Screenshots:

image

Detailed test instructions:

  1. Go to the MC setup flow and it should have four steps
  2. The button text of the third step should be "Continue", and click on it should move forward to the "Confirm store requirements" step

Changelog entry

@eason9487 eason9487 requested a review from a team July 29, 2021 08:42
@eason9487 eason9487 self-assigned this Jul 29, 2021
@tomalec
Copy link
Member

tomalec commented Jul 30, 2021

📜 In the latest designs "Confirm store requirements" headers is on a white background, whereas in this PR it's transparent/grey
Screenshot from Figma

Copy link
Member

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code, tested locally, run unit tests and linters (Travis is disabled for this branch). Left few comments about to-be-addressed later issues. LGTM

@eason9487
Copy link
Member Author

eason9487 commented Aug 2, 2021

📜 In the latest designs "Confirm store requirements" headers is on a white background, whereas in this PR it's transparent/grey

Opened a follow-up #924 for this.

@eason9487 eason9487 merged commit 95116f3 into feature/contact-info Aug 2, 2021
@eason9487 eason9487 deleted the feature/863-mc-setup-flow branch August 2, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants