Skip to content

Commit

Permalink
Unify wording concerning the "known bad" (exclude from reports) flag
Browse files Browse the repository at this point in the history
  • Loading branch information
wolframroesler committed Apr 10, 2020
1 parent 3a31efc commit 2b35040
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions src/gui/entry/EditEntryWidgetAdvanced.ui
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,10 @@
<item>
<widget class="QCheckBox" name="knownBadCheckBox">
<property name="toolTip">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;If checked, the password will not appear in reports like Health Check and HIBP even if it doesn't match the quality requirements (e. g. entropy or re-use). Set the check mark if the password quality is out of your control (e. g. if it needs to be a four-digit PIN) to prevent it from cluttering these reports.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;If checked, the entry will not appear in reports like Health Check and HIBP even if it doesn't match the quality requirements (e. g. password entropy or re-use). You can set the check mark if the password is beyond your control (e. g. if it needs to be a four-digit PIN) to prevent it from cluttering the reports.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
<property name="text">
<string>Exclude from security checks/reports (e. g. known bad password)</string>
<string>Exclude from reports (e. g. because of a known bad password)</string>
</property>
</widget>
</item>
Expand Down
12 changes: 6 additions & 6 deletions src/gui/reports/ReportsWidgetStatistics.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ namespace
int nPwdsShort = 0; // Number of passwords 8 characters or less in size
int nPwdsUnique = 0; // Number of unique passwords
int nPwdsReused = 0; // Number of non-unique passwords
int nPwdsKnownBad = 0; // Number of known bad passwords
int nKnownBad = 0; // Number of known bad entries
int pwdTotalLen = 0; // Total length of all passwords

// Ctor does all the work
Expand Down Expand Up @@ -142,7 +142,7 @@ namespace

if (entry->customData()->contains(PasswordHealth::OPTION_KNOWN_BAD)
&& entry->customData()->value(PasswordHealth::OPTION_KNOWN_BAD) == TRUE_STR) {
++nPwdsKnownBad;
++nKnownBad;
}

pwdTotalLen += pwd.size();
Expand Down Expand Up @@ -242,10 +242,10 @@ void ReportsWidgetStatistics::calculateStats()
QString::number(stats->nPwdsWeak),
stats->nPwdsWeak > 0,
tr("Recommend using long, randomized passwords with a rating of 'good' or 'excellent'."));
addStatsRow(tr("Number of known bad passwords"),
QString::number(stats->nPwdsKnownBad),
stats->nPwdsKnownBad > 0,
tr("Having passwords that are known to be bad isn't necessarily a problem, but you should keep an eye on them."));
addStatsRow(tr("Entries excluded from reports"),
QString::number(stats->nKnownBad),
stats->nKnownBad > 0,
tr("Excluding entries from reports, e. g. because they are known to have a poor password, isn't necessarily a problem but you should keep an eye on them."));
addStatsRow(tr("Average password length"),
tr("%1 characters").arg(stats->averagePwdLength()),
stats->isAvgPwdTooShort(),
Expand Down

0 comments on commit 2b35040

Please sign in to comment.