Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logging started getting pretty noisy #1419

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

luhring
Copy link
Member

@luhring luhring commented Jan 25, 2025

For multiple reasons, the log output shown to users by default started creeping up over time. This PR gets the default logging back to a healthy minimum (while still configurable to any crazy amount, of course!).

  • Logging for at least some commands used to default to WARN level. We recently cleaned up logging, but according to git bisect, commit d2196cd changed commands like "scan" to log at INFO by default, which is noisier than intended for the commands. This change sets the default logging level to WARN while preserving the ability to set it to INFO or higher if desired.
  • Updated apko to latest on main (v0.23.1-0.20250125200830-0b6b8a0543aa) to pick up logging noise improvements from fix(apk/client): silence request logging chainguard-dev/apko#1497.

Before

$ go run . scan -r crane
📡 Finding remote packages
2025/01/25 15:21:31 [DEBUG] GET https://packages.wolfi.dev/os/x86_64/APKINDEX.tar.gz
2025/01/25 15:21:31 [DEBUG] GET https://packages.wolfi.dev/os/aarch64/APKINDEX.tar.gz
2025/01/25 15:21:31 [DEBUG] GET https://apk.cgr.dev/chainguard-private/x86_64/APKINDEX.tar.gz
2025/01/25 15:21:31 [DEBUG] GET https://apk.cgr.dev/chainguard-private/aarch64/APKINDEX.tar.gz
2025/01/25 15:21:31 [DEBUG] GET https://apk.cgr.dev/extra-packages/aarch64/APKINDEX.tar.gz
2025/01/25 15:21:31 [DEBUG] GET https://apk.cgr.dev/extra-packages/x86_64/APKINDEX.tar.gz
2025/01/25 15:21:34 INFO downloaded APK path=/var/folders/pz/h07rtjmd4mv4wpnr5st5q1480000gn/T/packages.wolfi.dev-os-aarch64-crane-0.20.3-r1.apk1815856246
2025/01/25 15:21:34 INFO downloaded APK path=/var/folders/pz/h07rtjmd4mv4wpnr5st5q1480000gn/T/packages.wolfi.dev-os-x86_64-crane-0.20.3-r1.apk771089764
2025/01/25 15:21:34 INFO generating SBOM for APK file path=/var/folders/pz/h07rtjmd4mv4wpnr5st5q1480000gn/T/packages.wolfi.dev-os-x86_64-crane-0.20.3-r1.apk771089764 distroID=wolfi
2025/01/25 15:21:34 INFO generating SBOM for APK file path=/var/folders/pz/h07rtjmd4mv4wpnr5st5q1480000gn/T/packages.wolfi.dev-os-aarch64-crane-0.20.3-r1.apk1815856246 distroID=wolfi
2025/01/25 15:21:35 INFO finished Syft SBOM generation packageCount=19
2025/01/25 15:21:35 INFO finished Syft SBOM generation packageCount=19
🔎 Scanning "/var/folders/pz/h07rtjmd4mv4wpnr5st5q1480000gn/T/packages.wolfi.dev-os-aarch64-crane-0.20.3-r1.apk1815856246"
2025/01/25 15:21:35 INFO converted packages to grype packages packageCount=19
✅ No vulnerabilities found
🔎 Scanning "/var/folders/pz/h07rtjmd4mv4wpnr5st5q1480000gn/T/packages.wolfi.dev-os-x86_64-crane-0.20.3-r1.apk771089764"
2025/01/25 15:21:35 INFO converted packages to grype packages packageCount=19
✅ No vulnerabilities found

Now

$ go run . scan -r crane            
📡 Finding remote packages
🔎 Scanning "/var/folders/pz/h07rtjmd4mv4wpnr5st5q1480000gn/T/packages.wolfi.dev-os-x86_64-crane-0.20.3-r1.apk300702529"
✅ No vulnerabilities found
🔎 Scanning "/var/folders/pz/h07rtjmd4mv4wpnr5st5q1480000gn/T/packages.wolfi.dev-os-aarch64-crane-0.20.3-r1.apk2082852862"
✅ No vulnerabilities found

Logging for at least some commands used to default to WARN level. We recently cleaned up logging, but according to git bisect, commit d2196cd has commands like "scan" logging at INFO by default, which is noisier than intended for the commands. This change sets the default logging level to WARN while preserving the ability to set it to INFO or higher if desired.

Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Updated to latest on main (v0.23.1-0.20250125200830-0b6b8a0543aa) to pick up logging noise improvements from chainguard-dev/apko#1497.

Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
@luhring luhring enabled auto-merge January 25, 2025 20:32
@luhring luhring merged commit 9892832 into wolfi-dev:main Jan 27, 2025
4 checks passed
@luhring luhring deleted the log-hushing branch January 27, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants