-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeflow-pipelines-visualization-server: bump to use Python 3.11 #39639
Conversation
Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
Also, wanted to bump the tensorflow requirement to what we use, aka. 2.18.0, but actually one of the pip dependencies, I guess that was even tensorflow-data-validation 1.16.1 (latest), claimed it only supported tensorflow <2.17.0. So my bump in the requirements.txt had to be to 2.16.2 instead. |
Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this one seems like a difficult case - thanks for tackling it!
I'm concerned with diverging from upstream to move to 3.11 support. I wondered why upstream hadn't moved forward, and took a quick look at the project. It seems very active. But where there used to be both 2.3.0
and sdk-2.3.0
tags, there's now been 9 releases of just sdk-*
tags (2.4->2.11). I wonder if maybe they have restructured things somewhat, and we're stuck on a dead release.
As for how to validate these changes, the best way I can think of is to build them into the target image and run the image test case.
Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
Let me try building the image against the PR presubmit repo and see if that works as expected. |
Regarding this: I don't think we're necessarily 'diverging' from upstream by moving from 3.10 to 3.11. I didn't dig down |
hm, for unknown reasons I can't get the relevant image to build - both with the old and new package. It just gets stuck on "Creating...". Will investigate. |
Another package that was causing some images to pull in multiple Python bases.
This only bumps the used Python version to 3.11 as this is the max that google-cloud-sdk seems to support for now (see google-cloud-sdk.yaml). This also required bumping some pip dependencies.