Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak/26.1.0 package update #39598

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 15, 2025

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. labels Jan 15, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 15, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the build error, here's my analysis and suggested fix:

• Detected Error:

[ERROR] /home/build/services/src/main/java/org/keycloak/utils/SecureContextResolver.java:[7,21] package io.netty.util does not exist

• Error Category: Dependency

• Failure Point: Maven compilation step during the build process

• Root Cause Analysis: The build is failing because it cannot find the Netty utilities package, despite the pombump step attempting to add Netty dependencies. This suggests there's a missing or incorrect Netty dependency in the build configuration.

• Suggested Fix:
Add explicit Netty dependencies to the pombump configuration:

- uses: maven/pombump
  with:
    patch-version:
      - "io.netty:netty-util:4.1.115.Final"
      - "io.netty:netty-codec-http:4.1.108.Final"
      - "io.netty:netty-common:4.1.115.Final"
      - "io.quarkus.http:quarkus-http-core:5.3.4"

• Explanation:
The error indicates that while some Netty components are being patched, the specific netty-util package required by SecureContextResolver is missing. The fix explicitly includes all required Netty dependencies, ensuring the build has access to the necessary classes.

• Additional Notes:

  • Netty version alignment is important - using 4.1.115.Final to match the netty-common version
  • This matches the dependency structure seen in Keycloak's upstream pom.xml
  • The versions specified align with security-patched versions in Wolfi

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Jan 15, 2025
@OddBloke OddBloke self-assigned this Jan 15, 2025
@OddBloke OddBloke force-pushed the wolfictl-36eb735b-ae8b-48be-82a4-b01b8247f9ce branch from f75807b to c3ddb4a Compare January 15, 2025 17:15
@egibs egibs added the staging-build If this label is set on a PR, it will be built by elastic-build in staging label Jan 15, 2025
@OddBloke OddBloke force-pushed the wolfictl-36eb735b-ae8b-48be-82a4-b01b8247f9ce branch from c3ddb4a to d0d0c2c Compare January 15, 2025 17:29
@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed labels Jan 15, 2025
@OddBloke OddBloke force-pushed the wolfictl-36eb735b-ae8b-48be-82a4-b01b8247f9ce branch from 9804366 to 6be5e73 Compare January 16, 2025 17:10
@OddBloke OddBloke enabled auto-merge January 16, 2025 17:30
@OddBloke OddBloke requested a review from a team January 16, 2025 17:30
@OddBloke OddBloke merged commit 7ac7e12 into main Jan 16, 2025
21 checks passed
@OddBloke OddBloke deleted the wolfictl-36eb735b-ae8b-48be-82a4-b01b8247f9ce branch January 16, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. request-version-update request for a newer version of a package staging-build If this label is set on a PR, it will be built by elastic-build in staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants