pipelines: test: ldd-check: cleanups #39042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
reviewed
Jan 8, 2025
3281010 to
7953411
Compare
Error out if ldd was not able to actually reason about whether or not a file is a dynamic object by checking it's error message. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
7953411 to
24c6e58
Compare
smoser
requested changes
Jan 10, 2025
I started down this route just trying to fix 'continue' being called from a function (ratner than return). Then the nerd-snype / odd love for pain in shell hit me. Other things here: 1. just a single call to 'ldd' for each file. 2. if 'insist_dyn' is false, then we will just log a message instead of failing in the following cases: * not a file * does not exist * is not a dynamic executable This allows you to call it on all contents in a package and mostly get the results you want. 3. error if ldd exits other than 1 or 0 , and dump the output. 4. error (which exits immediately) if a package in 'packages' is not installed. 5. Please can we add a way to write pipelines in something else?
|
I pushed some changes. please @dannf and others review. |
smoser
previously approved these changes
Jan 10, 2025
murraybd
reviewed
Jan 17, 2025
Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
murraybd
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/wolfi-dev/os/pull/38563/files#r1906010589