Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle leading zeros and improve UX with default input fields #116

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Handle leading zeros and improve UX with default input fields #116

wants to merge 3 commits into from
+76 −117

Conversation

marcoancona
Copy link

New proposal, using normal input field, instead of type=number.
Advantages:

  • no need for additional span to handle leading zeros, while supporting all major browsers
  • update on ArrowUp/ArrowDown easily handled at parent level ('DateInput`), allowing for infinite date sequences (ie. 12-31-2018 -> focus on day 31 -> ArrowUp -> 01-01-2019)
  • validation on minDate/maxDate also handled in DateInput, which simplifies the logic of DayInput, MonthInputandYearInput` quite a bit

What do you think?

@marcoancona marcoancona mentioned this pull request Nov 5, 2018
Closed
@wojtekmaj wojtekmaj force-pushed the master branch 2 times, most recently from 10f9d1e to 8e53e44 Compare July 8, 2019 17:29
@wojtekmaj wojtekmaj force-pushed the main branch 3 times, most recently from bdde3a5 to dc151e8 Compare March 24, 2022 08:40
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from c4d58cf to 6dc7a09 Compare September 6, 2022 09:42
@wojtekmaj wojtekmaj force-pushed the main branch 8 times, most recently from ab5a30b to ff3a3ee Compare October 24, 2022 15:33
@wojtekmaj wojtekmaj force-pushed the main branch 5 times, most recently from 00ed12d to eb83192 Compare November 7, 2022 11:13
@wojtekmaj wojtekmaj force-pushed the main branch 5 times, most recently from 8182ad3 to 21af20c Compare November 7, 2022 12:58
@wojtekmaj wojtekmaj force-pushed the main branch 3 times, most recently from e1c7dc5 to a524886 Compare January 4, 2023 23:23
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 98e1adb to e253cd3 Compare March 2, 2023 08:43
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 0b4cd33 to 9dfdb34 Compare April 5, 2023 11:00
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from c1a58a8 to 84b1863 Compare July 21, 2023 18:59
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 37e50fb to 5584926 Compare October 23, 2023 10:20
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 1fd7f2d to daa2c24 Compare November 2, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcoancona