-
-
Notifications
You must be signed in to change notification settings - Fork 51
Fix wrapper.unmount not calling useEffect cleanup #22
Conversation
Would be helpful if this pull request was merged :) |
we are using this library as well and it would be very useful |
Hi @wojtekmaj Thank you so much helping us out! |
Nevermind I just saw your comment here
Thank you anyway though for this package!! |
@gisaklement I started discussing this change in a PR that adds official React 17 adapter this package is based on. Let's see how it goes. |
Thank you so much!! I appreciate it 🙂 |
Looks like we won't get an official response anytime soon. Screw this then. @Iskander508 Please kindly rebase your branch off current master, or allow edits from maintainers, so I could check if this doesn't break anything, since tests were added recently. |
Edits should be allowed already |
rebased |
Thanks so much. Interestingly this doesn't seem to affect neither positively nor negatively any unit tests originally added to Enzyme. Let's go for it. |
Again, thank you very much 🙂 |
fix for issue with unmount not running useEffect cleanup: #12