Fix usage instructions for bourne shell (sh/bash). #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is self-evident as a matter of syntax. With the previous instruction to `eval lesspipe.sh`, the shell will execute `lesspipe.sh` but simply echo its result to stdout. To set `LESSOPEN` the output needs to be eval'd, so capture it with the shell's $() command substitution. Demonstration: ``` $ unset LESSOPEN $ eval lesspipe.sh LESSOPEN="|/usr/bin/lesspipe.sh %s" export LESSOPEN $ echo $LESSOPEN $ eval "$(lesspipe.sh)" $ echo $LESSOPEN |/usr/bin/lesspipe.sh %s ``` Tested with GNU bash, version 5.1.16 (and a busybox `sh`).
wofr06
approved these changes
May 1, 2024
|
In Ubuntu 24_04 there is a default .bashrc file. There is a line to do the same for another version of lesspipe. I t was not present yet in Ubuntu 22_04. I changed my .bashrc to contain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is self-evident as a matter of syntax. With the previous instruction to
eval lesspipe.sh, the shell will executelesspipe.shbut simply echo its result to stdout. To setLESSOPENthe output needs to be eval'd, so capture it with the shell's $() command substitution.Demonstration:
Tested with GNU bash, version 5.1.16 (and a busybox
sh).