Fix error paginating queries containing the DISTINCT clause on SQL Server #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rver The application throws an exception when building queries with pagination for SQL Server if the query has no `ORDER BY` clause and the `DISTINCT` clause is present. This fix takes only the first column name of the query to build an `ORDER BY` clause.
No change in behavior.
|
@hprange Hi Henrique, does it still make sense to cherry pick this to Wonder6? |
|
@darkv Nah. Don't worry about that. If someone needs it in Wonder 6, they will shout. I removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application throws an exception when building queries with pagination for SQL Server if the query has no
ORDER BYclause and theDISTINCTclause is present. This fix takes only the first column name of the query to build anORDER BYclause.