Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle uvx like uv #920

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix: handle uvx like uv #920

merged 1 commit into from
Jan 31, 2025

Conversation

henryiii
Copy link
Collaborator

Copy link
Contributor

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing the warning

nox > Warning: uvx is not installed into the virtualenv, it is located at /Users/me/.local/bin/uvx. This might cause issues! Pass external=True into run() to silence this message.

I used uvx --with git+https://github.com/wntrblm/nox.git@refs/pull/920/head nox -rs <session>

PS: I also had to change nox.options.sessions to be a list since it was erroring with a tuple, so we should call it out in the future release notes.

@henryiii
Copy link
Collaborator Author

henryiii commented Jan 31, 2025

Oops, I thought about that when I started, but forgot about it by the time I added a test. I'll add it. Though I don't remember where we handle this for "uv".

@henryiii
Copy link
Collaborator Author

Where was nox.options.sessions a tuple?

@edgarrmondragon
Copy link
Contributor

Where was nox.options.sessions a tuple?

In my noxfile.py. I see the examples in https://nox.thea.codes/en/stable/config.html all use lists, so maybe only I was in the wrong 😅

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
Copy link
Collaborator Author

Can you try now? I'm looking into the over-validtion issue.

@edgarrmondragon
Copy link
Contributor

Can you try now? I'm looking into the over-validtion issue.

Aha, that did it!

@henryiii henryiii merged commit 97e0fad into wntrblm:main Jan 31, 2025
24 checks passed
@henryiii henryiii deleted the henryiii/fix/uvx branch January 31, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants